-
Notifications
You must be signed in to change notification settings - Fork 5
Implement second-order jack-knife lower bound on number of branches #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CyberiaResurrection
wants to merge
10
commits into
Zac-HD:master
Choose a base branch
from
CyberiaResurrection:ChaoBound
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dde7de9
Add storage for singletons/doubletons/etc for Chao bound
CyberiaResurrection fcb617d
Make space for estimated # of branches in dashboard
CyberiaResurrection 7ae0160
Add singleton/doubleton properties
CyberiaResurrection bc7543e
Implement basic Chao bound
CyberiaResurrection 422bc23
Convert report branches to int _before_ adding offset
CyberiaResurrection 3ff69e7
Fix line-length overruns
CyberiaResurrection b0c4196
Update CONTRIBUTING.md
CyberiaResurrection 7f21f08
Add tripleton/quadrupleton properties
CyberiaResurrection a1f3081
Only display bound after 10k inputs.
CyberiaResurrection 4a7fc35
Report second-order jack-knife bound instead of Chao
CyberiaResurrection File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? I believe we only store arcs that we have executed (via
CustomCollectionContext), which means singletons should be those with a count of 1, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arcs outside of the package, like in python itself, are also counted, which (since they're only run once during a given run) will only ever have a count of 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still use
== 1for singletons, and deal with "branches run only once" as I describe here by only counting branches which we can hit again by replaying the same input.