Introduce master key encryption with OS-backed device key support#10
Closed
Zayan-Mohamed wants to merge 3 commits intopre-v2from
Closed
Introduce master key encryption with OS-backed device key support#10Zayan-Mohamed wants to merge 3 commits intopre-v2from
Zayan-Mohamed wants to merge 3 commits intopre-v2from
Conversation
Signed-off-by: Zayan-Mohamed <itsm.zayan@gmail.com>
Release v2.0.0: Master key encryption model with recovery key support
Merge pull request #8 from Zayan-Mohamed/main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the security architecture change introduced in v2.0.0.
Before v2, vault encryption relied on a single password-derived key. This allowed offline brute-force attacks if a vault directory was stolen, because attackers could attempt to guess the password against encrypted data without any additional protection.
v2 introduces a layered key model:
This binds a vault to the physical machine, making offline attacks against stolen vault files infeasible without access to both the password and the original device.
A graceful fallback is provided when OS keyring storage is unavailable, allowing password-only operation when required for portability.
Security impact:
This PR exists to provide a formal design and review trail for the v2.0.0 security upgrade, which was previously merged directly into main.
Closes #2