fixed return condition #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

pvmm wants to merge 1 commit into Zeda:master from pvmm:master

pvmm commented Mar 27, 2023

I tested this code and it seems that the condition is reversed.


          fixed return condition

bbcf012

ped7g commented May 12, 2025

Review by reading the source:

yes, it should be ret nz and the dec hl should be done only when (hl) == 0 to return back to one leading zero char '0'.

Author

pvmm commented May 13, 2025

The ret nz guarantees that it is because it continues past that only if it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet