feat: add client-side search to journal entries #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e OPENMINDWELL_PROJECT_GUIDE.md to Project_Guide.md, and fix typo 'deatailed' to 'detailed' Co-authored-by: Cosine <agent@cosine.sh>
docs: fix README references, clone URL, and typo
… handling Co-authored-by: Cosine <agent@cosine.sh>
Member
|
kindly rebase your commit history! |
Blazzzeee
reviewed
Feb 10, 2026
Collaborator
Blazzzeee
left a comment
Blazzzeee
left a comment
There was a problem hiding this comment.
Please dont use useEffect for this , you should check on tanstack query and mutations
Comment on lines
+223
to
+241
| const [searchQuery, setSearchQuery] = useState(''); | ||
|
|
||
| useEffect(() => { | ||
| let isMounted = true; | ||
|
|
||
| async function loadEntries() { | ||
| try { | ||
| const data = await journalApi.getAll(); | ||
| if (!isMounted) return; | ||
| setEntries(Array.isArray(data) ? data : []); | ||
| } catch (err) { | ||
| console.error('Error loading journal entries:', err); | ||
| if (!isMounted) return; | ||
| setError('Failed to load journal entries.'); | ||
| } finally { | ||
| if (!isMounted) return; | ||
| setLoading(false); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
useEffect should only be used for external dependency sync , not render , please change this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a minimal client-side search to the Journal tab so users can quickly filter entries by title or content (case-insensitive).
No backend changes.
Closes #14
Type of Change
🐛 Bug fix
✨ New feature
💥 Breaking change
📚 Documentation update
🧹 Code refactoring
⚡ Performance improvement
✅ Test improvement
🔧 Build or CI/CD configuration changes
How Has This Been Tested?
Open Dashboard → Journal tab
Entries load correctly
Typing in search filters instantly (title OR content)
Case-insensitive
Clearing search shows all entries
Loading, empty state, and “no results” states verified
Screenshots
N/A (small UI addition only)
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
Additional Information
Frontend-only change.
Only frontend/src/pages/Dashboard.tsx modified.
No new dependencies.
Learning Outcomes
Improved understanding of client-side filtering and React state management.