Console warnings (Closes #7) #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedhapprakashni
requested review from
Blazzzeee and
ayushHardeniya
as code owners
ayushHardeniya
added
apertre3.0
Member
ayushHardeniya
left a comment
ayushHardeniya
left a comment
There was a problem hiding this comment.
hey! thanks for the pr but this is way too much for a simple cleanup issue. you basically built an entire feature we didnt ask for yet. closing this for now, pls stick to the issue description next time! also feels a bit like an AI dump which we dont really allow for feature work.
you can create another PR, but strictly fixing the desired task, and it'd be better if you support OSS and not using those LLM dumps here!
thanks again!
Author
|
@ayushHardeniya I'm sorry i just realized i just realized i wrongly added commits of another feature (Habit dashboard and check-in flow) in this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes console warnings about missing keys in React lists and removes duplicate footer element from the Home page. This resolves issue number 7.
Type of Change
Bug fix (non breaking change which fixes an issue)
Code refactoring (no functional changes)
How Has This Been Tested
Ran the dev server and verified console warnings are resolved. Checked that all list components render correctly with proper keys. Verified the Home page displays correctly with single footer.
File Changes made in this PR:
ChatRoom.tsx: Changed message list key from array index to unique identifier using msg.id or a combination of timestamp and userId. This prevents React key warnings when messages are added or removed from the list.
CheckInModal.tsx: Changed confetti animation key from plain index to prefixed string format using confetti followed by the index number. This ensures unique keys for the animated elements.
Home.tsx: Removed duplicate footer element. The page was rendering both an inline footer section and a separate Footer component, causing duplicate content to appear at the bottom of the page.
Learning Outcomes
Learned about React key best practices. Using array indices as keys can cause issues with component state and reconciliation when items are reordered, added, or removed. Unique identifiers should be used whenever possible to help React efficiently update the DOM.