feat(turborepo-rspack-mf): swap Router layout for Zephyr splash + MF live demo#173
Open
billwatson017 wants to merge 2 commits intomainfrom
Open
feat(turborepo-rspack-mf): swap Router layout for Zephyr splash + MF live demo#173billwatson017 wants to merge 2 commits intomainfrom
billwatson017 wants to merge 2 commits intomainfrom
Conversation
…live demo Replace the React-Router boundary-toggle layout with the canonical ZephyrWelcome splash, and showcase Module Federation with a live in-page demo rendered between the quick-start and pipeline blocks — mirroring the pattern in build-systems/nx-rspack-mf. Changes: - host: App.tsx now renders ZephyrWelcome with turbo-specific metadata (title, logos, pills). No more BrowserRouter, Routes, or the showBoundaries toggle button. - host: new ZephyrWelcome.tsx (fork supporting `mid` prop) and FederationDemo.tsx — two accent-colored boundary cards with toggle pills for turbo_home and turbo_settings. Mount/unmount each remote live. - host: delete AppLayout.tsx, Header.tsx, useLocalStorage.ts — no longer referenced. - home: rewrite RemoteEntry.tsx as "Catalog Team" product listing (amber theme, inline styles so it works standalone and embedded). - settings: rewrite RemoteEntry.tsx as "Activity Team" feed (violet theme). Verified: turbo build deploys all three apps; host resolves to fresh branch-specific remote URLs; splash + toggleable federated remotes + pipeline explainer render correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the same splash-page + Federation Demo pattern from #172 (nx-rspack-mf) to the Turborepo example. Replaces the React-Router boundary-toggle layout in
build-systems/turborepo-rspack-mfwith the canonicalZephyrWelcomesplash, and adds a live Module Federation demo rendered between the quick-start and pipeline blocks.What changed
App.tsxnow rendersZephyrWelcomewith Turborepo + Rspack + MF metadata. No moreBrowserRouter,Routes, or theshowBoundariestoggle button.ZephyrWelcome.tsx+FederationDemo.tsxinapps/host/src/— copied from the nx refactor, adapted for turbo remote names (turbo_home,turbo_settings). Two accent-colored boundary cards with toggle pills that mount/unmount each remote live.AppLayout.tsx,Header.tsx,useLocalStorage.tsdeleted; no longer referenced.Live demo
https://bill-watson-eh3huzb2he-629-turbo-host-zephyr-exam-1f5174193-ze.zephyrcloud.app
Test plan
pnpm install && pnpm buildinbuild-systems/turborepo-rspack-mf/deploys all 3 appspnpm dlx degitcommandRelated
build-systems/nx-rspack-mfNote on concurrency
Turbo's default parallel build can race Zephyr's registry update: on a first-time
pnpm build, the host may resolve old CI remote URLs. Running the host build a second time picks up the fresh branch remotes. Not a regression — the Nx example had the same behavior before it forced--parallel=1. Worth a follow-up to set up a turbo task dependency between host and remotes.