Parser tail rec

[ThunderMikey]

Make parser tail recursive in order to parse longer Markdown files.

[ThunderMikey]

I tested the JS in VS-Code, but when I tried to preview the example.fmark, it showed "resource is not available".

[ps-george]

It's a problem with file includes, think it is windows only? It changes every time they update Vs code :(

[ThunderMikey]

What should we doooooo?

[ps-george]

For testing your PR you can see if fmark.example works without a file include! And we'll fix that issue later :(

[ThunderMikey]

No luck. Even with only one line of normal text.

[ymherklotz]

Hmm, did you actually managed to make it tail recursive though? I can test it out later if it works on my linux

[ThunderMikey]

I tried it on Linux, the debug console said js-beauty not found.

[ymherklotz]

Ahh ok, yeah, when testing you have to use yarn to update and install the missing packages. I think yarn install at the base of the repo should do. Then you'll be able to test it.

This is in the VSCode repo though.

[ThunderMikey]

I did yarn install, as the result, no error showed up in the console this time. However, the FMark Preview stays blank no matter what I do in a .fmark file.

[ymherklotz]

Did you check the debug log? Were there still no errors there? That is very weird. I ll have a look at it as soon as I have time, which should be end of next week.

[ps-george]

@ThunderMikey parser is now tail recursive? nice

[ThunderMikey]

Yeah, just don't know whether the other issues has been solved or not.

[ps-george]

Did we get anywhere with figuring out the bug with this? Does the master branch work in its current state?

[ymherklotz]

Need to add a test that parses a large markdown file, like 10000 lines, and hopefully completes under 1sec and does not crash.

#180

[ps-george]

@ThunderMikey, you removed a lot of |> Ok, result.map, & result.bind/makeOk in the code.

Could you explain why? Did you replace with an equivalent, or are results no longer needed because the functions "won't fail" / don't have a fail condition?

[ThunderMikey]

@ps-george If I recall correctly, I did not want the function to fail, at the very least, fmark will spit something even though the text is malformatted.

We can probably improve this by having different states (error states will be used to inform the user) while spitting the text.