-
Notifications
You must be signed in to change notification settings - Fork 0
Add point cloud network support #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0d968bd to
503fbe6
Compare
|
You'll have to include the |
503fbe6 to
7dede48
Compare
7dede48 to
01f0d27
Compare
|
@nkemnitz done |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.02%
==========================================
Files 181 182 +1
Lines 8942 8955 +13
==========================================
+ Hits 8940 8952 +12
- Misses 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nkemnitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage is failing... that means pointcloud.py is not collected during the load_all_modules() test. If that's on purpose, you need to add that file to the omit list in .coveragerc.
Add try/except import in architecture/__init__.py so pointcloud network registrations are loaded when zetta_utils modules are loaded. The import is wrapped in try/except to handle environments without the pointnet package installed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
For reference, with PCG we print a warning: https://github.com/ZettaAI/internal/blob/07677dc1c40fb3aa882406a717417927cc248912/__init__.py#L11C1-L17C67
|
Summary
pointnetpackage for PointNet/PointNet++ modelsChanges
zetta_utils/convnet/architecture/pointcloud.pymodulepointcloudoptional dependency in pyproject.toml