Skip to content

Conversation

@lovasoa
Copy link

@lovasoa lovasoa commented Jun 4, 2023

fix typo

@p-avital
Copy link
Collaborator

p-avital commented Jun 4, 2023

Hi,

Thanks for the fixes, especially on the bools, that's a much clearer sentence.

The ECA check didn't pass, which is necessary to commit to this repo to ensure the license doesn't break (from my understanding, I'm not a lawyer, I've just been told it's important).

You can either sign the thing, or we've had a previous case of someone not wanting to make an account on Eclipse, whose PR was merged after they posted the following:

I state that I was not able to sign ECA with my GitHub private email,
since I wouldn't want to disclose my public email for this particular commit,
and that therefore I grant the permission to copy/merge my PR if accepted

If that suits you better, feel free to just reply with that, and I'll merge your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants