posix_spawnp is unavailable on watchOS and tvOS#8
Open
cloutiertyler wants to merge 1 commit intoZewoGraveyard:masterfrom
Open
posix_spawnp is unavailable on watchOS and tvOS#8cloutiertyler wants to merge 1 commit intoZewoGraveyard:masterfrom
cloutiertyler wants to merge 1 commit intoZewoGraveyard:masterfrom
Conversation
Current coverage is 83.08% (diff: 0.00%)@@ master #8 diff @@
==========================================
Files 14 14
Lines 856 857 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 712 712
- Misses 144 145 +1
Partials 0 0
|
ronflima
reviewed
May 1, 2017
| } | ||
| } | ||
|
|
||
| #if !os(watchOS) && !os(tvOS) |
Contributor
There was a problem hiding this comment.
Instead of using #if, you should use @available annotation which is appropriate to accomplish your intentions.
| #endif | ||
|
|
||
|
|
||
| #if !os(watchOS) && !os(tvOS) |
Contributor
There was a problem hiding this comment.
You should use @available annotation instead of #if
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added compiler directive to leave out the spawn functions if building on watchOS or tvOS as those are not available on those platforms.