Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧾 fix(ui): estabilización UX + logout seguro + coherencia visual
Base:
origin/mainRama:
fix/ui-ux-stability🧾 Qué se cambió
🧩 Groups
GroupRepository.getAllGroups()ahora usa la key del snapshot como source of truth para leer/Groups/Users/<groupKey>y hace fallback denamesi viene vacío.🧠 Welcome BottomSheet (EditProfile)
🧾 BottomSheet (Compose)
ZibeBottomSheetfuerzaModalBottomSheetPropertiescon system bars en modo oscuro mientras el sheet está abierto (evita icons/texto oscuros y mejora consistencia visual).🧭 ChatList
ContextMenude long-press porPopupMenuestilado (mismo look & feel que el overflow).🧵 Coroutines / errores
zibeCatchingahora re-lanzaCancellationException(no se trata como error).ProfileViewModelpara no mostrar diálogo cuando es cancelación (evita "Standalone Coroutine was cancelled" al navegar rápido).🔒 Logout (crashes + UX)
ChatList:stopObserving()deja de recalcular refs que requieren usuario logueado (usa/cacha refs).ProfileRepository: manejo seguro de cancelaciones/permission issues en listeners RTDB durante sign-out.🔧 Por qué
namefaltaba en meta (terminaba consultando/Groups/Userssin child → rules →PERMISSION_DENIED).ModalBottomSheetcambiaba el estado visual de system bars al abrir/cerrar.ContextMenuvsPopupMenu).♻️ Contratos
zibeCatching {}:CancellationExceptionya no se encapsula comoFailure→ se re-lanza (comportamiento correcto de coroutines).ZibeButtonPrimary: nuevo parámetroiconSize: Dp = 24.dp(Auth lo usa en40.dppara Google/Facebook).PopupMenu+ recurso nuevomenu_chat_list_item.xml.🔥 Código muerto
ContextMenude ChatList deja de usarse (migrado aPopupMenu).✅ Tests agregados (JVM)
✅ Cómo correr los tests
✅ Checklist manual
unreadCount.CHAT_STATE_SILENT.📦 Commits incluidos
6517d 🧩 arregla la carga de grupos cuando falta name en meta y muestra "Salas próximamente"fecdf 🧠 mantiene el flag del welcome a través del logout (no se resetea)aa7d2 🧾 fuerza system bars en modo oscuro mientras el bottom sheet está abiertoe1906 🧭 unifica el menú de long-press con el estilo del overflow usando PopupMenua3129 🧵 re-lanza cancelaciones y evita diálogos de error por cancelación en Profilefe66d 🔒 evita crashes en logout (listeners + cancelaciones/RTDB)ff7f1 ⏳ permite definir iconSize en botón primario para iconos sociales732aa 🧱 agrega overlay global de loading durante logout🚧 Fuera de alcance