This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Don't fail when outgoing message amounts sum to more than current balance#989
Closed
Don't fail when outgoing message amounts sum to more than current balance#989
Conversation
Contributor
Author
|
The tests I've added should be replicated on the C++ side as well, especially for the case where the recipients are user accounts. From Scilla's point of view a user account behaves like a contract that defines the following transition for every possible transition name (as well as the empty string): |
vaivaswatha
approved these changes
May 23, 2021
Contributor
Author
|
Converting to draft, pending discussions with @AmritKumar and others. |
Contributor
Author
|
Closing, as this PR is superseeded by #1032 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scilla uses acceptance semantics, so we should not throw an error just because a contract sends out more money than it has. The error should not occur to until the recipients have accepted more funds than the contract has.
I'm unsure what we should output as the balance in the json output. Several options make sense: