ZCS-1467: IMAPD Configuration on Admin Console UI#42
ZCS-1467: IMAPD Configuration on Admin Console UI#42haitran1696 wants to merge 1 commit intodevelopfrom
Conversation
grishick
left a comment
grishick
left a comment
There was a problem hiding this comment.
@haitran1696 please add bind ports for IMAP and IMAPD to global config settings for IMAP and IMAPD tabs and change the corresponding fields on Server tab to be SUPER_TEXTFIELD (or whatever is the appropriate field that implements fallback to global config)
haitran1696
force-pushed
the
Bugfix/ZCS-1467
branch
from
a494afd to
29ccfdf
Compare
|
Hi @grishick, I updated as your request. Please tell me if I need to update anything else. Thank you! |
|
@silentsakky I downloaded the changes, deployed to my dev docker and tested |
| }, { | ||
| type:_ZA_TOP_GROUPER_, | ||
| label:ZaMsg.Global_IMAPD_NetworkGrp, | ||
| items: [{ |
| var invalidValues = []; | ||
| var isValidValue = true; | ||
|
|
||
| if (ZaItem.hasWritePermission(ZaServer.A_zimbraReverseProxyUpstreamImapServers,obj)) { |
There was a problem hiding this comment.
isn't this same as ZaServerController.prototype.validateReverseProxyUpstreamImapServers ?
| } | ||
| ZaXFormViewController.preSaveValidationMethods["ZaServerController"].push(ZaServerController.prototype.validateReverseProxyUpstreamImapServers); | ||
|
|
||
| ZaServerController.isValidHostName = function (isHostNameStr) { |
There was a problem hiding this comment.
can you please correct indentation in this function?
| this.attrs[ZaServer.A_zimbraAutoProvScheduledDomains] = [this.attrs[ZaServer.A_zimbraAutoProvScheduledDomains]]; | ||
| } | ||
|
|
||
| if(this.attrs[ZaServer.A_zimbraReverseProxyUpstreamImapServers] && !(this.attrs[ZaServer.A_zimbraReverseProxyUpstreamImapServers] instanceof Array)) { |
| style: DwtAlert.INFO, | ||
| iconVisible: false, | ||
| content: ZaMsg.Alert_ServerRestart | ||
| }] |
haitran1696
force-pushed
the
Bugfix/ZCS-1467
branch
8 times, most recently
from
87ef074 to
a719b2f
Compare
|
Hi @silentsakky, I updated the code. Please review and tell me if something needs to be changed. Thank you! |
| //Check validation of reverse proxy upstream imap server: host name or IP address format | ||
| var invalidValues = []; | ||
| var isValidValue = true; | ||
| if(ZaItem.hasWritePermission(ZaGlobalConfig.A_zimbraReverseProxyUpstreamImapServers,tmpObj)) { |
There was a problem hiding this comment.
is this code same as ZaServerController.prototype.validateReverseProxyUpstreamImapServers ?
There was a problem hiding this comment.
Can you please explain in detail what is different here?
There was a problem hiding this comment.
ZaItem.hasWritePermission checks permission of account modified this attribute and check this attribute can be modified or not.
ZaServerController.prototype.validateReverseProxyUpstreamImapServers checks validating parts of input value.
haitran1696
force-pushed
the
Bugfix/ZCS-1467
branch
from
a719b2f to
400aab1
Compare
|
Alex Tran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
4 participants
No description provided.