Skip to content

Conversation

@ZimperiumBrian
Copy link

Problem

When console_url ends with a trailing slash, the action attempts to normalize it by trimming the slash.

However, baseUrl is currently declared as const, which causes a runtime crash when reassignment is attempted.

Evidence

GitHub Actions runtime error:

TypeError: Assignment to constant variable.
at dist/index.js:44471

Fix

Change const baseUrl to let baseUrl so trailing-slash normalization works correctly.

Impact

Prevents the action from crashing when users configure console_url with a trailing slash.
This aligns with the existing normalization logic already present in the code.

@ZimperiumBrian ZimperiumBrian requested a review from a team as a code owner December 19, 2025 00:04
@exlegalalien exlegalalien requested review from exlegalalien and removed request for a team December 22, 2025 15:03
@exlegalalien
Copy link
Contributor

Will fix in a separate branch/PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants