Conversation
…hide-version, respectively
In my opinion it should be explicitly stated that identity depends on hide-indentity set to no. And similar to version, and hide version. Since the condition is short, I find being highly verbose in such cases much more helpful than the current quietness. The reader must be noted that I haven't checked the actual code. The patch could be wrong in assuming that if hide-{identity,verbose} is set to yes, identity and verbose will not be reported. Hopefully, a reviewer has better knowledge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hide-version, respectively
In my opinion it should be explicitly stated that identity depends on hide-indentity set to no. And similar to version, and hide version. Since the condition is short, I find being highly verbose in such cases much more helpful than the current quietness. The reader must be noted that I haven't checked the actual code. The patch could be wrong in assuming that if hide-{identity,verbose} is set to yes, identity and verbose will not be reported. Hopefully, a reviewer has better knowledge.