Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes two small changes: it updates the firework rocket cooldown logic to handle both gliding (elytra boost) and ground/block firework usage scenarios, and adds %weight_class% placeholder replacement support in queue selector GUI items.
Changes:
- Replaced the elytra-equipped check in
FireworkRocketCooldownListenerwith a gliding-state and action-type check, so cooldowns apply for elytra boosts and block-placed fireworks, but not for right-clicking air without gliding. - Added
%weight_class%placeholder replacement inQueueSelectorGuifor both the raw template (used by the real-time ticker) and after LB-format lore processing inupdateIconWithQueueData.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
spigot_modern/.../FireworkRocketCooldownListener.java |
Replaced elytra-equipment guard with a gliding + action-type guard for firework rocket cooldowns |
core/.../QueueSelectorGui.java |
Added %weight_class% placeholder replacement in raw template setup and after leaderboard lore replacement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| // - Player gliding with elytra (boost attempt) OR | ||
| // - Any non-air click (ground/block usage) | ||
| // Ignore empty RIGHT_CLICK_AIR without gliding | ||
| if (!player.isGliding() && e.getAction() == Action.RIGHT_CLICK_AIR) { |
There was a problem hiding this comment.
The new guard condition only filters out RIGHT_CLICK_AIR when the player is not gliding, but it does not filter out left-click actions (LEFT_CLICK_AIR, LEFT_CLICK_BLOCK) or PHYSICAL. This means if a player holds a firework rocket and left-clicks (e.g., to attack), the cooldown handler will still fire and set a material cooldown on FIREWORK_ROCKET, preventing the player from actually using the rocket for boosting until the cooldown expires.
Consider also filtering out non-right-click actions by adding a check like action != Action.RIGHT_CLICK_AIR && action != Action.RIGHT_CLICK_BLOCK early return, or alternatively only proceeding on right-click actions.
… default color fallback to gray
…n it can and admin wants to open it
…layer leaving ffa arena
* fix: prevent false firework cooldown and optimize by using EntitySpawnEvent * chore: remove unused imports * fix: include FFA arenas in enabled arena count * fix: update CopyGui synchronously to prevent duplicate icons
…ed blocks by fireballs
…s, changed event start sound to only play when under 5 seconds
…e there is a change in the config.yml
No description provided.