Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts ladder enablement rules and spectating behavior to better support FFA ladders/spectator switching, and tightens kill attribution logic in matches.
Changes:
- Allow enabling normal ladders without requiring
matchTypesto be assigned. - When spectating an FFA, automatically stop spectating any previous match/FFA first; allow
/ffa spectatefromSPECTATEstatus. - Prevent awarding void-kill credit to the victim themself when using “last attacker” attribution.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/src/main/java/dev/nandi0813/practice/manager/ladder/util/LadderUtil.java | Removes the “no match type assigned” gate when enabling a ladder. |
| core/src/main/java/dev/nandi0813/practice/manager/ladder/abstraction/normal/NormalLadder.java | Updates isReadyToEnable() to no longer require non-empty matchTypes; adds (currently unused) import. |
| core/src/main/java/dev/nandi0813/practice/manager/fight/match/Match.java | Avoids crediting the victim as killer in void attribution logic. |
| core/src/main/java/dev/nandi0813/practice/manager/fight/ffa/game/FFA.java | Removes a spectator from any prior Spectatable before adding them to this FFA. |
| core/src/main/java/dev/nandi0813/practice/command/ffa/arguments/SpectateArg.java | Permits running and tab-completing the spectate command from SPECTATE status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
core/src/main/java/dev/nandi0813/practice/manager/ladder/abstraction/normal/NormalLadder.java
Outdated
Show resolved
Hide resolved
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| if (ffa.getPlayers().containsKey(player)) { | ||
| Ladder oldLadder = ffa.getPlayers().get(player); | ||
| if (oldLadder == ladder) { | ||
| Common.sendMMMessage(player, LanguageManager.getString("FFA.COMMAND.KIT.ALREADY-IN-KIT").replace("%ladder%", ladder.getDisplayName())); |
…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…action/normal/NormalLadder.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.