updated vapory for python under windows and made a bugfix for 16 bit images#13
Open
eelcovv wants to merge 4 commits intoZulko:masterfrom
Open
updated vapory for python under windows and made a bugfix for 16 bit images#13eelcovv wants to merge 4 commits intoZulko:masterfrom
eelcovv wants to merge 4 commits intoZulko:masterfrom
Conversation
|
Hello , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Zulko,
First of all, many thanks for this python api for pov-ray, it is exactly what I was looking for!
I installed it last week and started working with it. I am working with python3 under windows and fixed some errors which were related to differences between python under linux and windows. In the windows version, piping is not allowed so in order to return the image inmediately to a numpy array you have to a temporary write it to file. So I have added that. Also the name of the povray executatble is different (not povray, but pvengine64.exe). Finally I added a bug fix for 16 bit images. In order to set the byte order, it should be >u2 en not >uint16. this later may be a typical python3 change so you may want to check that. Anyway, in case you are interested to merge my changes, please go ahead.
Regards