Release 20251015 #22
Merged
Release 20251015 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix sdk mtls testing logic
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const mtlsBaseUrl = forcePort444 && !baseUrl.includes(':444') | ||
| ? (baseUrl.includes(':444') | ||
| ? baseUrl.replace(':444', ':444') |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
The fix is to remove the redundant replace operation and simply return baseUrl in this else-branch.
Specifically, in createACubeMTLSConfig, lines 93–97 build the mtlsBaseUrl.
- Remove the unnecessary
baseUrl.replace(':444', ':444')call (line 95). - Let the branch simply refer to
baseUrlwhen':444'is already present. - No further imports or helper methods are necessary.
Only this region in the filesrc/core/adapter-loader.tsneeds to change.
Suggested changeset
1
src/core/adapter-loader.ts
| @@ -92,7 +92,7 @@ | ||
|
|
||
| const mtlsBaseUrl = forcePort444 && !baseUrl.includes(':444') | ||
| ? (baseUrl.includes(':444') | ||
| ? baseUrl.replace(':444', ':444') | ||
| ? baseUrl | ||
| : baseUrl.replace(/:\d+$/, '') + ':444') | ||
| : baseUrl; | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
…s integration - Add getCertificatesInfo() method to ACubeSDK for fast certificate info access - Update ExpoMutualTLSClass interface with all expo-mutual-tls features - Implement parseCertificate methods (P12 and PEM parsing support) - Add getCertificatesInfo() native method to retrieve stored certificate metadata - Implement proper getCertificateInfo() using expo-mutual-tls getCertificatesInfo() - Add removeAllListeners() method for proper event cleanup - Add new SDKError types: MTLS_ADAPTER_NOT_AVAILABLE, CERTIFICATE_INFO_ERROR - Fix CertificateInfo interface compatibility in Node.js adapter - Add detailed certificate parsing with subject, issuer, validity, fingerprints - Extract pemId and cashRegisterUUID from certificate commonName - Add comprehensive debug logging for certificate operations - Complete feature parity with @a-cube-io/expo-mutual-tls library 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
feat: add comprehensive certificate info retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.