Open
Conversation
ehcache.xml spilitted into 2 parts: ehcache.xml and localCache.xml. In ehcache.xml placed settings for distributed cache, in localCache.xml - local pm cache
Added migration script and new entity performed changes on service level to use PostDraft class for saving drafts
This should prevent sending save draft requests from topic creation page
Now we ignore duplicates when inserts data to POST_DRAFT table Added Restore_Drafts.sql to rollback deletion of draft if something goes wrong
JC-2179 - Clean all unused
Path variable "id" was renamed to "questionId" because spring-mvc thinks that "id" is a part of PostDto model attribute
Now we check if post textarea exist inside js
- refresh img wrapped with <button>, since can't focus img. - Added #refreshCaptchaBtn id to tabNavigation list. - changed refreshCaptcha function because click event caused POST request to nonexistent resource.
- refresh img wrapped with <div>, since img tag can't be in focus . - added style 'btn-captcha-refresh' which overrides bootstrap button style. - added class '.btn-captcha-refresh' to tabNavigation list. - added separated keyboard handler to update captcha through keyboard. - restored button style and sign up form behaviour. - Plugin test updated since plugin template changed. (cherry picked from commit ff2ebac)
While the functions were defined through Function Declaration and were
working fine, after minification (by wro4j) the code became broken.
Wro4j replaced Function Declaration with Function Expression
(using `var = function(){}`), but left that function declared at the
bottom which resulted in function undefined in the code at the top.
Couldn't find a bug for wro4j. Didn't raise one either, maybe we'll do
it later.
…pages containing errors
Now we not save draft during reload of page if draft has not been changed
Now content itself is checked as well if the length didn't change. Also, started to refactor Drafts' logic into OOP style: - It will be easier to understand - It will allow us writing unit tests for JS in the future - It will be easier to move to IoC frameworks if needed
-When choosing a particular contact type it should be able to put anything into the input field and no validation will happen. -The only constraint should be 255 symbols max. -In case contact is too large when looking at it on the UI, it should end with "..." and the rest of the contact should not be shown.But it still should be clickable.
Using custom processor for escaping of HTML because standard Velocity escaping utility not correct displays emoji. Changed version of kefirbb library to 1.5
Added version of user profile in URL of avatar for showing new uploaded avatar. Minor refactoring of EditUserProfileDto for removing unhelpful Javadoc.
…info pages (/errors/404 etc)
…p error info pages (/errors/404 etc)" This reverts commit e5fe24e.
…info pages (404 etc)
- added spam protection functionality that helps to avoid spam-bots registration.
Tomcat can't remove JCUser objects from thread-local variables after application stop, so let's remove them after each Http request.
… in integration tests level.
JC-2373 Fixed: XSS in Q&A topic title Fixed smyleys are displayed as rhombuses in draft of answer.
- checkbox and icon now are on the same line - removed tooltips for Enabled checkbox activation/deactivation - fixed null-pointer exception in SpamProtectionService when email is null - spaces are completely trimmed in "regex" and "description" fields - fixed typo in spam-rule management dialog - added word wrapping for regex and description columns - added regex pattern validation - added test for regex pattern validation - added pop-up with 'Access Denied' message on spam protection page - updated Spring Security to 3.1.1 This was necessary to facilitate the process of managing access to API
- added button (isn't visible by default, to see button in 'group users administration page' you should add url request param 'display-button=on')
- added possibility to focus Edit rule and Delete rule icons with TAB - changed error message for Rule regex and description fields - fixed title for Edit Rule pop up - fixed grammar mistakes - fixed html validation errors
- removed JS code from global.js that was used for redirect to external links. - removed getHrefPrefix method and it's usages in addPrefixToForeignLinks method. - removed test method postprocessorShouldCorrectlyAddPrefix. - renamed addPrefixToForeignLinks -> addRelNoFollowToForeignLinks. - fixed the rest test methods in BBForeignLinksPostprocessorTest.java.
…ail matching pattern
- Added searchUsersDialog - Added ability to search users in searchUsersDialog - Added ability to add selected users to group
- FAB tool tip is absent. Fixed - Change user adding to group pop up UI and functionality. Fixed - Open the autocomplete list after entering any character. Fixed - Check field length error message is shown for 51 symbols entered. Fixed
Some of the crappy dependencies that were used back in the days are not available. Including ours like spring-security patch (https://github.com/jtalks-org/spring-security-patch). At least included our dependency so that one of the modules could be built. JTalks Common dependencies still need (and can) be built locally and installed into local maven repository manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.