Feature/2025/03/06 improve dcql complex query UI#433
Feature/2025/03/06 improve dcql complex query UI#433acrusage-iaik wants to merge 9 commits intodevelopmentfrom
Conversation
Add: Going back and forth retains selected credentials Add: Show request summary in initial screen Add: Show credential query details when selecting credentials
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2eb1cf98b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| !it.required && it.options.all { | ||
| it.any { | ||
| selectedSubmissionIndices[it]?.isNotEmpty() != true | ||
| confirmedSubmissionIndices[it]?.isNotEmpty() != true | ||
| } | ||
| } && index.toUInt() !in selectedCredentialSetQueryOptionIndices.keys |
There was a problem hiding this comment.
This branch now mixes confirmedSubmissionIndices with selectedCredentialSetQueryOptionIndices, so after a user picks an optional option (unconfirmed) the optional chooser disappears, but its credential queries are still excluded from requestedCredentialQueries (which is based on confirmed options). In a DCQL request with optional credential sets, that can skip the credential-selection step and submit without the optional data the user just chose.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is intended, as long as the submission isn't confirmed with "Confirm", it should be excluded from requestedCredentialQueries. This allows going back to the previous selection while preserving the selected items
| onContinue = onContinueWithSelection.takeIf { | ||
| selectedOptionIndex != null | ||
| }, |
There was a problem hiding this comment.
The optional page encodes the "no optional dataset" choice as null, but continue is gated by selectedOptionIndex != null, so choosing "none" leaves the continue action disabled indefinitely. This traps users on the optional-step screen unless they select a real option, which changes the consent outcome.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is intended, for optional credential sets there is always the option to choose to send no data.
nodh
left a comment
nodh
left a comment
There was a problem hiding this comment.
Nice! does this also work for DCAPI requests coming in?
There was a problem hiding this comment.
These queries can be used for manual testing, moved to commonTest to make this clear
| } | ||
|
|
||
| is CredentialPresentationRequest.PresentationExchangeRequest -> { | ||
| // TODO? |
There was a problem hiding this comment.
So there is no preview of requested attributes when using presentation exchange, e.g. on proximity calls?
| onToggleSelection = onToggleSelection, | ||
| option = option, | ||
| ) | ||
| // selectableCredentialSubmissionCards = matchingResult.value.matchingResult.credentialQueryMatches.mapValues { |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Yes, this also works with DCAPI, but it seems like DCAPI only allows selection of 1 credential anyway, and non-selected credentials aren't even shown in that case Also changed it so that unsuitable credentials are not selectable and their card is shown with disabled colors. This is reasonable since there is no matching result anyway, so we couldn't even submit them if we wanted to. 
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
2 participants
Change: Improve UI flow
Add: Going back and forth retains selected credentials
Add: Show request summary in initial screen
Add: Show credential query details when selecting credentials
Add: Show error messages for non-matching credentials