Open
Conversation
nodh
requested changes
Jan 7, 2026
openid-data-classes/src/commonMain/kotlin/at/asitplus/openid/CredentialFormatEnum.kt
Show resolved
Hide resolved
vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/openid/OpenId4VpVerifier.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/IsoMdocPresentation.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/PresentationDataClasses.kt
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/ValidatorMdoc.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/ValidatorMdoc.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/Verifier.kt
Outdated
Show resolved
Hide resolved
opsiv
commented
Jan 8, 2026
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/ValidatorMdoc.kt
Outdated
Show resolved
Hide resolved
opsiv
commented
Jan 8, 2026
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/IsoMdocPresentation.kt
Outdated
Show resolved
Hide resolved
- allow for params to be serialized depending on zk system in use - implement custom serializer for ZkSystemSpec to accomodate change
- added basic functionality to support presenting IsoMdocs in ZK - custom DCQL Query can now be correctly interpreted and routed to ZK
…Spec - Prover can now use dcql requests to generate proofs with Iso mDoc ZkDocuments - simplified converting DCQLZkSystemType to Iso's ZkSystemSpec
opsiv
force-pushed
the
feature/openidMdocZk
branch
from
54b8890 to
d5291a0
Compare
Author
|
Addressed the issues (except KmmResult) |
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5291a0c49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
openid-data-classes/src/commonMain/kotlin/at/asitplus/iso/ZkSystemSpecSerializer.kt
Show resolved
Hide resolved
openid-data-classes/src/commonMain/kotlin/at/asitplus/iso/ZkSignedItemSerializer.kt
Show resolved
Hide resolved
Member
|
Will be easier to review once #469 is merged |
nodh
reviewed
Jan 29, 2026
| ) : DCQLCredentialMetadataAndValidityConstraints { | ||
| val doctypeValue: String, | ||
|
|
||
| // TODO: Think about creating a DCQLIsoMdocZkCredentialMetadataAndValidityConstraints class instead |
Member
|
@opsiv Please rebase onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic support for Zero-Knowledge Proof systems in ISO mDoc (Preparation for longfellowZk implementation)
Please review @nodh