This repository was archived by the owner on Oct 18, 2024. It is now read-only.
Bug fix for Fast5_to_seq_summary for directories with 1 fast5 file#137
Open
godotgildor wants to merge 1 commit intoa-slide:masterfrom
Open
Bug fix for Fast5_to_seq_summary for directories with 1 fast5 file#137godotgildor wants to merge 1 commit intoa-slide:masterfrom
godotgildor wants to merge 1 commit intoa-slide:masterfrom
Conversation
Currently, the code looks at the enumerate index `i` to see if a fast5 file was found in the given directory. However, if a directory does not have any files in it, then the enumeration loop won't get started and the `i` variable will actually be unbound, so the code as written would raise an `UnboundLocalError`. If there is a single fast5 file in the directory, then `i` will be valid, but it will be `==0`. I've updated the logic to use a simple flag to indicate when we have actually inserted a fast5 file into the Queue during this loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the code looks at the enumerate index
ito see if a fast5 file was found in the given directory. However, if a directory does not have any files in it, then the enumeration loop won't get started and theivariable will actually be unbound, so the code as written would raise anUnboundLocalError. If there is a single fast5 file in the directory, theniwill be valid, but it will be==0, causing the current code to error saying that no fast5 files were found.I've updated the logic to use a simple flag to indicate when we have actually inserted a fast5 file into the Queue during this loop.