test(jolt-transcript): add DigestTranscript regression coverage#1428
Open
umeeSthein wants to merge 1 commit intoa16z:mainfrom
Open
test(jolt-transcript): add DigestTranscript regression coverage#1428umeeSthein wants to merge 1 commit intoa16z:mainfrom
umeeSthein wants to merge 1 commit intoa16z:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add focused regression tests for the generic
DigestTranscriptimplementation introduced in the recent transcript refactor.These tests cover a few generic behaviors that were not exercised directly before:
challenge_vectoradvances the internal round counter correctlycompare_toaccepts matching transcript historiescompare_todetects divergence and panics as expectedThe coverage is kept intentionally narrow to avoid duplicating the broader alias-level tests that already exist for
Blake2bTranscriptandKeccakTranscript.