Refactor fluid simulation code for clarity #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor fluid assembly code to unify 2D/3D functions and improve readability.
This PR consolidates the
fluid_2d_c/mandfluid_3d_c/mfunctions into unifiedfluid_unified_candfluid_unified_mfunctions, reducing code duplication by approximately 1,000 lines. It introduces smaller, focused helper functions (e.g.,interpolate_fields,compute_strain_rate_tensor,compute_viscosity_terms) that map directly to specific equation terms, enhancing readability, maintainability, and alignment with the referenced VOF paper. The original functions are retained as wrappers for backward compatibility.