Changed import of factorial for SciPy>1.0 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alias scipy.misc.factorial is deprecated sicne scipy 1.0. Instead, scipy.special.factorial should be used.
rpvandenderen
approved these changes
Jun 23, 2020
- included missing `scale_from_period` class methods in `Paul` and `DOG` wavelet classes - fixed indexing in transform.py: `cwt_time` used a list of slices to index a 2D array. In future versions of NumPy this will trigger at best an `IndexError`, at worst NumPy might try to silently interpret the list as array index which will yield the wrong result. Changes to be committed: modified: wavelets/transform.py modified: wavelets/wavelets.py
Added missing scale_from_period functionality for Paul + DOG wavelets
Contributor
|
So is this project abandoned? |
Contributor
|
Update: Yes, this project is abandoned and I've tried to make mine the replacement: #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alias scipy.misc.factorial is deprecated sicne scipy 1.0. Instead,
scipy.special.factorial should be used.