Remove all warnings when running spec and install tasks#2
Open
wkjagt wants to merge 1 commit intoaarongough:masterfrom
Open
Remove all warnings when running spec and install tasks#2wkjagt wants to merge 1 commit intoaarongough:masterfrom
wkjagt wants to merge 1 commit intoaarongough:masterfrom
Conversation
- Updated Rakefile to use latest version of RSpec and fixed all specs to use :expect instead of :should. - Updated Rakefile to use fixed versions of all dependencies - Added MIT licence to Rakefile to remove warning from install task - Fixed some minor bugs lambda.scm and set.scm - Have RSpec raise on deprecations
Author
|
Oh by the way, I realize this is an old project, and I completely understand if you don't merge this :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a great project. I think I'll have a lot of fun with this.
However, when I tried to run the specs for this, I got lots of deprecation warnings. Probably because the latest version of RSpec was installed. Also, two tests were false positives because
raise_errordidn't specify what error was expected, and a different one was raised.This PR:
Rakefileto explicitly use version 3.3.0 of RSpec and adapts allspecs to use the new
:expectinstead of the deprecated:shouldform.Rakefileto use fixed versions of all dependencies (rake installwas complaining about the absence of versions)gemspec.license = "MIT"to Rakefile to remove another warning fromrake install.lambda.scmandset.scmFlea::EnvironmentandFlea::Interpreterin the specs because they were failing because of it (tbh, I haven't investigated why).The trailing white space removal is from my editor. Let me know if it bothers you.