Skip to content

fix: Check if unit is player before rendering tooltip #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danlemmond wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Check if unit is player before rendering tooltip #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Widgets/CreatureRankingTooltip/widget.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,21 @@ local creature_avg_lvl = {}
function Deathlog_activateCreatureRankingTooltip()
if loaded_crt == false then
GameTooltip:HookScript("OnTooltipSetUnit", function()
local a, id = GameTooltip:GetUnit()
if UnitIsPlayer(id) then
return
end

if deathlog_settings[widget_name]["enable_crt"] then
if creature_ranking then
local a, _ = GameTooltip:GetUnit()
local rank = creature_ranking[a]
if rank then
GameTooltip:AddLine("#" .. rank .. " deadliest in Azeroth", 0.6, 0.6, 0.6, 0.6, true)
GameTooltip:AddLine("#" .. rank .. " deadliest mob in Azeroth", 0.6, 0.6, 0.6, 0.6, true)
end
end
end

if deathlog_settings[widget_name]["by_zone"] then
local a, _ = GameTooltip:GetUnit()
local _zone = C_Map.GetBestMapForUnit("player")
local instance_id = nil
local zone_name = ""
Expand All @@ -39,7 +42,7 @@ function Deathlog_activateCreatureRankingTooltip()
local rank = creature_ranking_by_zone[_zone][source_id]
if rank then
GameTooltip:AddLine(
"#" .. rank .. " deadliest in " .. zone_name .. ".",
"#" .. rank .. " deadliest mob in " .. zone_name .. ".",
0.6,
0.6,
0.6,
Expand All @@ -51,7 +54,6 @@ function Deathlog_activateCreatureRankingTooltip()
end

if deathlog_settings[widget_name]["enable_avg_lvl"] then
local a, _ = GameTooltip:GetUnit()
if creature_avg_lvl[a] then
GameTooltip:AddLine(
"Avg. victim lvl. " .. string.format("%.1f", creature_avg_lvl[a]),
Expand Down