Fix/filtering by apys on Market page #2755
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| useEffect(() => { | ||
| if (supplyDisplayApy === undefined) return; | ||
| onApyChange(id, 'supply', supplyDisplayApy); | ||
| }, [id, onApyChange, supplyDisplayApy]); |
There was a problem hiding this comment.
let's remove onApyChange from useEffect deps to avoid unwanted re-renders
same in others
|
|
||
| const meritIncentivesAPR = meritIncentives?.breakdown?.meritIncentivesAPR || 0; | ||
| const selfAPY = ENABLE_SELF_CAMPAIGN ? meritIncentives?.variants?.selfAPY ?? 0 : 0; | ||
| const totalMeritAPY = meritIncentivesAPR + selfAPY; |
There was a problem hiding this comment.
For some reason, meritIncentivesAPR has been kept with this name (probably to avoid conflicts between files), but it actually represents the APY.
| return hasInfiniteIncentives | ||
| ? 'Infinity' | ||
| : isBorrow | ||
| ? protocolAPY - (protocolIncentivesAPY as number) - totalMeritAPY - merklIncentivesAPR | ||
| : protocolAPY + (protocolIncentivesAPY as number) + totalMeritAPY + merklIncentivesAPR; |
There was a problem hiding this comment.
maybe we can remove this one because we have something similar in useIncentivizedApy.ts?
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
General Changes
Developer Notes
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files