Run transport check in a new thread to prevent UI freeze

[aarnapant-sap]

fix: Run transport check in a new thread to prevent UI freeze

• The previous implementation of the transport check was running on the main UI
  thread, which caused the application to become unresponsive during long
  operations.

• This change moves the transport check to a ModalContext thread, ensuring the
  UI remains responsive and providing visual feedback to the user via a modal
  progress dialog.

[abinbaby-sap]

Minor refactoring and exception handling suggestions:

1. Shall we move the transport check into a separate method which returns the check data?
2. monitor.done can be added in a finally block
3. There are mainly two exceptions from the process, InterruptedException ( caused if it is cancelled ) and InvocationTargetException ( when any exception occurs inside the code block ). Added some suggestions for the handling of these. Please have a look and also test it once.

	private IAdtTransportCheckData getTransportCheckData(IAdtObjectReference packageRef) {
		WizardPage currentPage = ((WizardPage) getContainer().getCurrentPage());
		IAdtObjectReference checkRef = IAdtCoreFactory.eINSTANCE.createAdtObjectReference();
		checkRef.setUri(packageRef.getUri());

		final IAdtTransportCheckData[] checkData = new IAdtTransportCheckData[1];

		try {
			getContainer().run(true, true, monitor -> {
				try {
					monitor.beginTask(Messages.AbapGitWizardPageTransportSelection_transport_check, IProgressMonitor.UNKNOWN);
					checkData[0] = AbapGitWizardPull.this.transportService.check(checkRef, packageRef.getPackageName(), true);
				} finally {
					monitor.done();
				}
			});
			return checkData[0];
		} catch (Exception exception) {
			handleError(exception, currentPage);
		}
		return null;
	}

	private void handleError(Exception exception, WizardPage currentPage) {
		currentPage.setPageComplete(false);
		Throwable cause = exception instanceof InvocationTargetException ? exception.getCause() : exception;
		if (cause != null && cause instanceof OutDatedClientException) {
			AdtUtilUiPlugin.getDefault().getAdtStatusService().handle(cause, null);
		} else {
			currentPage.setMessage(cause != null ? cause.getMessage() : exception.getMessage(), DialogPage.ERROR);
		}
	}

[aarnapant-sap]

Yeah I will modularize the transport check data code

[abinbaby-sap]

d -> dialog

[aarnapant-sap]

sure

[abinbaby-sap]

Could this be done after d.close() inside the thread? Will that work? So that only after closing the wizard we will open this dialog.

[aarnapant-sap]

yeah that should work.

[abinbaby-sap]

we could call the new method for handling the OutDatedClientException right?

[aarnapant-sap]

yeah I forgot to change this implementation with method name