fix(v2k): stabilize libvirt cutover defaults for live migration#18
Merged
fix(v2k): stabilize libvirt cutover defaults for live migration#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a v2k cutover issue where KVM guests created from migrated VMs could fail live migration due to unstable libvirt/QEMU default device synthesis, especially around
virtio-balloon.It also refreshes the
ablestack_v2kCLI help and CLI guide so defaults and examples match the current implementation more closely.Changes
memballoonwithautodeflateandfreePageReportingvirtio-serialguest agent channelvirtiotocirrusdownin generated XML--compat-profiledefaults toautoeven when omitted--helpoutput with:cutoverbut not yet reflected in generated XMLstatus --vm .../--watchusagedocs/v2k/v2k_cli_guide.mdto match the updated help and current behaviorRoot Cause
v2kwas generating a minimal libvirt domain XML and relying on libvirt defaults for several devices. In the failing case, the resulting domain included an auto-synthesizedvirtio-balloon, and live migration failed while restoring its state on the destination host.By making key devices explicit in the generated XML, the resulting guest definition becomes more predictable and more aligned with the migration-stable domain shape already validated in the environment.
Files Changed
lib/v2k/target_libvirt.shtests/v2k_compat_installer_runtime_smoke.shbin/ablestack_v2k.shdocs/v2k/v2k_cli_guide.mdValidation
Validated in code by:
upstream/maincompat-profile=autoEnvironment limitation:
Notes
cutoverstill accepts--vcpu,--memory,--network,--bridge, and--vlan, but those values are not yet reflected byv2k_target_generate_libvirt_xml(). This PR documents that behavior clearly in help/docs rather than changing that interface implicitly.