Open
Conversation
- Update Rails dependency to support Rails 8.x in gemspec - Replace deprecated sign_in method with bypass_sign_in - Update I18n translation syntax for Rails 8 compatibility - Fix File.exists? deprecation in generators - Use dynamic migration versions for future compatibility - Preserve original migration structure (up/down methods) - Update Ruby requirement to >= 3.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Note: We have a green CI on the website using this branch
Rails 8 Compatibility Test Results
✅ Success: Net +4 Test Improvements
Fixed by Upgrade
Pre-existing Issues (unchanged from main)
Copilot Summary
This pull request updates the codebase for compatibility with Rails 8 and modern Ruby versions, refactors authentication flows, improves internationalization usage, and cleans up legacy code and tests. The changes focus on upgrading dependencies, ensuring migration and generator compatibility, updating authentication methods, and improving error handling and translation usage.
Rails 8 and Ruby 3+ compatibility:
Gemfileanddevise_google_authenticator.gemspecfor Rails 8 and Ruby 3+, including newer versions ofactiverecord,sqlite3, and test gems. Also set minimum Ruby version to 3.0.0 and updated runtime dependencies for Rails 8 support. [1] [2] [3]ActiveRecord::Migration.current_versionand Rails 8 migration context, ensuring compatibility with the latest Rails migration system. [1] [2] [3] [4] [5]Authentication and controller improvements:
sign_inwithbypass_sign_inin authentication flows for better Devise compatibility and security. [1] [2]devise_error_messages!with a partial for shared error messages.Internationalization and translation updates:
I18n.t('devise.registration.title')) instead ofscope:option, for consistency and modern Rails conventions. [1] [2] [3]Code quality and test improvements:
File.exist?,head :ok, improved resource path name logic, addedattr_accessorforgauth_token). [1] [2] [3] F42b04b0L1, [4]