Jwt authentication nodejs #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utorials into jwt-authentication-nodejs
fliptopbox
force-pushed
the
jwt-authentication-nodejs
branch
from
ff7043e to
d7da718
Compare
- repaced old logo with static asset - replaced old UI with ably-ui like form - updated JavaScript to ES6 - Added missing package.json
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
[EDU-765] CHORES Jwt authentication nodejs fix
Update README.md
SimonWoolf
reviewed
Aug 30, 2024
server.js
Outdated
| res.setHeader("Content-Type", "application/json"); | ||
|
|
||
| console.log(": Sending signed JWT token back to client:\n%s", tokenId); | ||
| res.send(JSON.stringify(tokenId)); |
There was a problem hiding this comment.
Why are we JSON-stringifying a string (which will just wrap it in quotes) and then setting an application/json content-type? that makes no sense.
It looks like ably-js handles that because ably-js is very accommodating, but there's no guarantee any other sdk will.
We should send the string as a string, with a text/plain or application/jwt content-type.
Fix: don't JSON-encode JWT and update content type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.