Make apache-2.0 and lgpl rules more specific #4597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rules are AND rules. Thus they should only match if both licenses are actually detected in the text. There are a bunch of rules that have similar problems. Since the rules touched in this diff caused problems for us, I am just touching them and and consider remaining rules out of scope. Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The rules are AND rules but they also match if only Apache-2.0 is present. Of course, they should only match if both licenses are actually detected in the text.
Summary
Require Apache 2.0 and LGPL to be present in the text for these rules to match.
Out of scope
There are a bunch of rules that have similar problems. Since the rules touched in this diff caused problems for us,
I am just touching them and and consider remaining rules out of scope.
Test Plan
I would have added a test, but I can't run scancode locally on my arm mac due to #3539 (but on recent versions of MacOS and Scancode)
Tasks
Run tests locally to check for errors.