Profiles keep back and forth detours via points #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2026 17:53
Otherwise some waypoints may not really be routed to (Brouter would remove route sections that go forward and then backwards on the same ways). This is visible with the Brouter service on Android, not in brouter-web. The engine default used to be hard coded to 40 but was then set to 0 (disable) in 901dd3a. This commit was then merged in c72fc5f. This change sets correctMisplacedViaPoints (set as the default: true) and correctMisplacedViaPointsDistance as profile global parameters so that they can be changed in an easy way by the user.
Same as previous commit but for those two profiles as well.
Contributor
Author
|
Tests failed because of Github Internal Server Error HTTP 500 (they are having issues right now, see https://www.githubstatus.com/). |
and correctMisplacedViaPointsDistance as well (also adding unit)
Contributor
Author
|
I added a rephrasing of the developer documentation which had the desired side effect of starting the tests again and pass them (no more HTTP 500 errors on Github). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise some waypoints may not really be routed to (Brouter would remove
route sections that go forward and then backwards on the same ways).
This is visible with the Brouter service on Android, not in brouter-web.
The engine default used to be hard coded to 40 but was then set to 0 (disable)
in 901dd3a. This commit was then merged in c72fc5f (PR #764).
This change sets correctMisplacedViaPoints (set as the default: true) and
correctMisplacedViaPointsDistance as profile global parameters so that they
can be changed in an easy way by the user.
Should address issue #825.