Conversation
Split PK Passes and Nano Passes into separate artifact, update metadata fields.
Updated to use 'creation_date' and 'last_update_date' fields. Refactored all artifact functions to use a Context object and unified plist file reading via get_plist_file_content. Reordered output columns
Replaced nska_deserialize with get_plist_content for plist deserialization.
Adds validation for plist deserialization
Reorganized imports and replaced custom _parse_blob with get_plist_content
Ensure plist_content is a dict before checking for '$archiver' key in get_plist_content and get_plist_file_content.
minor code cleanups
|
@Johann-PLW can you take a look at the |
|
most of the linter errors are from ilapfuncs, but there is one in an artifact module. can you fix this? then i think we can open an issue to describe the plist parse blob problem to reserve it to fix another time. then we can get these modules merged in. |
|
@JamesHabben I solved the lint error. Also, I've noticed this plist parsing logic is repeated in several files. Do you think it would be a good idea to extract it into a function in ilapfuncs? That way, we can handle any parsing issues or logic changes in a single place instead of updating every artifact |
|
@Maite2003 looks like we still have a bunch of linter stuff |
|
@stark4n6 the lint errors are from ilapfuncs, not from the modules or code related to this PR. thats stuff that one of us needs to clean up in core code. @Maite2003 i think we should open an issue to discuss the plist code and see about putting it into core code vs the module. can you open that and explain the problem? mention any other modules that you know of that are using similar code. |
|
@Maite2003 can you let us know if you created an issue for the plist code? If so please link here. Otherwise we need to get one created so we can clear this PR. |
3 participants
Pk passes, WorldClock, applicationStateDB and wifiPlist are tested. I couldn't find data on transactions or Nano passes