Merged
Conversation
Replaced manual plist parsing and timestamp conversion with utility functions
Updated the artifact to use the new v2 structure, replaced direct plistlib usage with get_plist_content, and refactored the function to use the artifact_processor decorator and context object. Removed manual reporting code and improved timestamp conversion.
changed parameters to context
context object removed unused imports changed plist logic to use function
removed unnecessary parentheses from the return statement
- context object - closed db before returning - removed unused imports.
- context object - removed unused imports
Collaborator
|
@Maite2003 some small linter issues, looks like they could be resolved quick, then I think we can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectedDevices and controlCenter are tested with the test data in the admin folder. Data usage is tested with ios15 image. For the rest i couldn't find test data