fix (parsecdCache): missing 'score' column on older iOS#1374
Merged
stark4n6 merged 1 commit intoabrignoni:mainfrom Feb 4, 2026
Merged
fix (parsecdCache): missing 'score' column on older iOS#1374stark4n6 merged 1 commit intoabrignoni:mainfrom
stark4n6 merged 1 commit intoabrignoni:mainfrom
Conversation
zelvann
changed the title
Collaborator
|
@stark4n6 I tested this. It works fine with dataasets that have the "score" column still. Should be good to merge. I think this is a more complete solution as compared to the portion of PR #1393 that attempts to address this. #1393 only wraps in a try/except but this PR actually dynamically selects the columns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no column named "score" in the
completion_cache_engagementtable. Although the data exists, it is still not reported because it throws an error message. To handle this, I first check whether the column exists or not by usingpragma table_info. If it is, it or "score" will be reported with other columns. Otherwise, it will still be reported without the "score" columnHave tested with iOS versions 12 and 13 (There is no column "score" yet).
Please, review this along with the check using the table with the score column.