fix(netusage): handle exceptions during timestamp conversion#1388
Open
Tokenzrey wants to merge 1 commit intoabrignoni:mainfrom
Open
fix(netusage): handle exceptions during timestamp conversion#1388Tokenzrey wants to merge 1 commit intoabrignoni:mainfrom
Tokenzrey wants to merge 1 commit intoabrignoni:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug in netusage.py that causes the artifact parser to crash when processing
netusage.sqlitedatabases containing invalid or NULL timestamps.Previously, the parser would fail completely upon encountering a single invalid timestamp string (e.g., an empty string returned by SQLite's
datetimefunction), resulting in total data loss for this artifact. This update implements defensive programming to handle these exceptions gracefully.Changes
try-exceptblocks aroundconvert_ts_human_to_utccalls in netusage.py.ValueErrororTypeErroroccurs during conversion, the timestamp is set to'N/A'instead of crashing the script.Verification & Testing
I have created a comprehensive test suite (test_netusage_fix.py) to verify the fix and ensure no regressions.
Test Output Summary:
Checklist
Related Issues
Closes #1389