Skip to content

fix: skip invalid user defaults plists #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo08S wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Open

fix: skip invalid user defaults plists #1413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions scripts/artifacts/userDefaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from plistlib import InvalidFileException
import sys
import datetime
from scripts.ilapfuncs import artifact_processor
from scripts.ilapfuncs import artifact_processor, logfunc

@artifact_processor
def user_defaults(files_found, report_folder, seeker, wrap_text, timezone_offset):
Expand Down Expand Up @@ -49,14 +49,22 @@ def user_defaults(files_found, report_folder, seeker, wrap_text, timezone_offset
if f'{bundleid}.plist' in file_found and guid in file_found:
found_apps.append(guid)
with open(file_found, "rb") as fp:
plist = None
if sys.version_info >= (3, 9):
try:
plist = plistlib.load(fp)
except InvalidFileException as e:
plist = 'INVALID FILE'
except InvalidFileException:
logfunc(f'Invalid plist encountered: {file_found}')
else:
plist = biplist.readPlist(fp)
for (key,item) in plist.items():
try:
plist = biplist.readPlist(fp)
except (InvalidFileException, ValueError):
logfunc(f'Invalid plist encountered: {file_found}')

if not isinstance(plist, dict):
continue

for (key, item) in plist.items():

data_list.append((bundleid, guid, key, clean_data(item), file_found))

Expand Down
Loading