Open
Conversation
- package.json changed dependencies since i could not install via npm -- "filesaverjs": "^1.2.1" could not be resolved. -- "bable-core" came with the new file-saver version -- updated "flow-bin" since it had some issues when i run npm install - save_midifile.js -- adapted to new file-saver !! No testing done - sampler.js -- returns the actual Sampler instance in promise now - init_audio.js -- had issues here with chrome policy !! Dont know it it can be done like this -- there might be issues on other places in code when initAudio() is never called. - init.js -- removed void return since actually a promise is returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hallo abudaan,
I really like your Project and appreciate very much the effort you put into it. Unfortunately i could not install the current version. Via "npm install qambi" there were issues with filesaverjs.
https://www.npmjs.com/package/filesaverjs
The Project is deprecated and moved. I updated the package.json and got basic things to work on my local machine.
(
(btw https://raw.githubusercontent.com/gleitz/midi-js-soundfonts/master/FluidR3_GM/ defined in the instrument.json's is also no longer valid (movedTo:http://gleitz.github.io/midi-js-soundfonts/FluidR3_GM/)
i used baseUrl in the data object to overide it)
)
Sequencer in Audio performs really nice also when there load on animationFrames. And it provides the actual midi tick which is exactly what i need.
Thanks for your great work, i hope the PR is useful to you (at least in part). I just wanted to give some "Feedback" to your great work.
Best Regards,
Bernd
package.json changed dependencies since i could not install via npm
-- "filesaverjs": "^1.2.1" could not be resolved.
-- "bable-core" came with the new file-saver version
-- updated "flow-bin" since it had some issues when i run npm install
save_midifile.js
-- adapted to new file-saver
!! No testing done
sampler.js
-- returns the actual Sampler instance in promise now
init_audio.js
-- had issues here with chrome policy
!! Dont know it it can be done like this -- there might be issues on other places in code when initAudio() is never called.
init.js
-- removed void return since actually a promise is returned.