Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am aware that I don't need to justify my decisions for an optional code, but I'd prefer to write them down somewhere, and it might as well be here.
This code is meant to skip mandatory cutscenes. Wholly optional cutscenes (such as acquiring Shadow at the Old Man's house) are not skipped. For simplicity's sake, optional parts of mandatory cutscenes are often skipped. If there is a choice between two or more different cutscenes, all are skipped. In-battle cutscenes are not skipped. I considered cutscenes in Locke's scenario to be mandatory despite the Kutan glitch's existence.
In all cases, I wanted the game to exit every cutscene in the exact state it should have ended. The party should be in the same place, the correct music should be playing, and the correct event bits should be set. Any differences can be considered a defect. A secondary goal is to prevent it from looking butt-ugly, though it isn't perfect in that regard.
This code currently only skips cutscenes up until the battle at Narshe.
Some notable points:
-Gau is still auto-recruited correctly. My code for this was sloppy, admittedly. I can fix it if desired.
-The characters should all have their correct randomized palettes.
-The Phantom Train music doesn't kick in properly for a while. If the cutscene at the train door is removed entirely, the music won't kick in before it ends. In this case, it will never start if the player enters a battle. I increased the tempo of the music and put in a delay to wait for the music to kick in. If the player walks straight to the door as usual, it won't feel too weird, but the train noises will be sped up for a while if they decide to run around the cabin.
-Noises were added to inform the player that they succeeded in talking to mandatory NPCs who would otherwise show no indication of progress. For example, a noise will play when giving the old man his cider.