Windows: Refactor DLL creation on Cygwin/MinGW env #128
+16
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes conditional type for os.setf(), which was failing on msys2 llvm environment and replaces it by auto type. Signed-off-by: Jerome Haxhiaj <jhaxhiaj@qti.qualcomm.com>
|
This pull-requests depends on #127 |
Windows DLLs can't contain unresolved symbols. Therefore systemc, when built with MSYS2, is split in two libraries: libsystemc-<version>.dll without unresolved symbols and libsystemc.a with unresolved symbols. Currently, cmake target systemc (exposing libsystemc.a) is aliased as SystemC::systemc This leads to a situation where projects that depend SystemC::systemc would link only against the systemc.a and drop the dll. This commit introduces the interface target library `systemc_if`, which links against systemc dll and static and is aliased as SystemC::systemc. To insure backward compatiblity, this mechanism is enabled only when systemc is built as a shared library This commits reworks the sections that merges libsystemc.a and libsystemc-<version>.dll.a
jeromehaxhiaj-qti
force-pushed
the
windows_on_arm64_ci
branch
from
42cb9d0 to
036b9e3
Compare
jeromehaxhiaj-qti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows DLLs can't contain unresolved symbols. Therefore systemc,
when built with MSYS2, is split in two libraries: libsystemc-.dll
without unresolved symbols and libsystemc.a with unresolved symbols.
Currently, cmake target systemc (exposing libsystemc.a) is aliased as SystemC::systemc
This leads to a situation where projects that depend SystemC::systemc
would link only against the systemc.a and drop the dll.
This commit introduces the interface target library
systemc_if,which links against systemc dll and static and is aliased as SystemC::systemc.
To insure backward compatiblity, this mechanism is enabled only
when systemc is built as a shared library
This commits reworks the sections that merges
libsystemc.a and libsystemc-.dll.a