fix: prevent crash when variable data is undefined #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two regression issues in
TemplateMarkInterpreterwhere missing or undefined data caused the engine to crash during generation. These issues were preventing themainbranch from passing tests.Issues Addressed
nodesarray), causing aValidationException.No values found for path...), the interpreter would explicitly throw an Error, halting execution.Changes
TemplateMarkInterpreter.ts:generateAgreementto safely remove Clause, Conditional, and Optional nodes entirely if their required data is missing.generateAgreementto default missing Variable values to string'null'instead of throwing a hard error.TemplateArchiveProcessorandTemplateMarkInterpreterto reflect that missing data now results in empty output or placeholder text rather than a crash.Verification
I have verified locally that
npm testnow passes all suites, including the regression tests that were failing onmain.