Skip to content

Comments

merge original in#4

Open
acdifran wants to merge 65 commits intoacdifran:masterfrom
dracula:master
Open

merge original in#4
acdifran wants to merge 65 commits intoacdifran:masterfrom
dracula:master

Conversation

@acdifran
Copy link
Owner

No description provided.

DerekStride and others added 30 commits March 5, 2021 09:33
* Add hightlight groups for nvim-treesitter

The majority of this configuration was taken from
ChristianChiarulli/nvcode-color-schemes.vim#14
by [@nitishvelu](https://github.com/nitishvelu). I made a few minor
tweaks based on a ruby project to make sure most of the original tokens
were colored similarly.

* tree-sitter highlights conform to dracula spec

* Use builtin highlight groups

Co-authored-by: Derek Sifford <dereksifford@gmail.com>

* Apply suggestions from code review

Co-authored-by: Derek Sifford <dereksifford@gmail.com>

Co-authored-by: Derek Sifford <dereksifford@gmail.com>
…232)

* Ignore highlight groups from the default treesitter config

https://github.com/nvim-treesitter/nvim-treesitter/blob/master/plugin/nvim-treesitter.vim

* Remove TSError highlight

I mistakenly thought the TSError highlight group was used for
highlighting error types. However upon further investigation into
#231 I discovered it's actually
applied to syntax errors.

While typing out new code, treesitter is unable to parse the new code
and will highlight with TSError, in most cases we don't want that to
show up as an Error since we're not finished typing. See
nvim-treesitter/nvim-treesitter#78 (comment)
for more infomation.
This adds specific highlight groups for GitGutter-related things.
It piggybacks off of the `Diff*` highlight groups.

The `gitsigns.nvim` maintainer [suggested](lewis6991/gitsigns.nvim#94) that this be
implemented by checking if neovim is >= version 0.5, and if the package is
available (as opposed to a variable like `g:loaded_gitsigns`). This is because
`gitsigns` is essentially lazy-loaded so checking the variable when Dracula loads might be too early.

See these other related links in from [gitsigns](https://github.com/lewis6991/gitsigns.nvim):
lewis6991/gitsigns.nvim#54
lewis6991/gitsigns.nvim@317750d
Closes #235.

The default syntax/tex.vim links texRefZone to Special, making it more
like a regular LaTeX command than plain-text.
Adds LspReference groups so that the reference highlighting feature
works for neovim built-in LSP.

Co-authored-by: Mathew Robinson <mathew@chasinglogic.io>
update installation instructions for other OS
Related: #192, #210, #248

Also #247 is about `NonText`, which needs investigating.

Issues: `:digraphs`, special keys in `:map` output, and certain parts of
`'listchars'` are "subtle" and hard to read (esp. w/ `cursorline` over
them). Also, vim uses `SpecialKey` for them (instead of `Whitespace` for
`'listchars'` and `SpecialKey` elsewhere, like NeoVim).

Fix: make `SpecialKey` more like special keys (the highlight in vimscript
for, e.g., `map <Space> :echo "hello"<CR>`). This has the side effect of
making digraphs more visible. It also makes certain `'listchars'` pink,
which may be annoying. But there is no way currently to separate the two
in vim.

Rationale: It matches with the special keys in maps. The fact that vim
uses it elsewhere may simply be "wrong" and need changed.

If you don't like it: well, as usual, you can use an autocommand to use
whatever colors you want (`:help dracula-customization`).
* Highlight tag attributes via tree sitter.

* Comments about tree-sitter hightlight groups.
/screenshot.png -- 526.38kb -> 328.13kb (37.66%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
[ImgBot] Optimize images
* add option to set full special attributes support

This is useful to inform Dracula that the current UI has full support
for special attributes like underlines and undercurls, as by default it
assumes no terminal emulator have such support.

The default value falls back to the current behavior, assuming only
graphical interfaces have full support.

Fix #266

* fix grammar issues

Co-authored-by: D. Ben Knoble <ben.knoble+github@gmail.com>

* add documentation for the new option

Co-authored-by: D. Ben Knoble <ben.knoble+github@gmail.com>
for backward compatibility with neovim v0.5.x
Co-authored-by: D. Ben Knoble <ben.knoble+github@gmail.com>
Add nvim-cmp kind highlights
style to DraculaWinSeparator. Link DraculaWinSeparator to VertSplit.
feat(nvim): Add support for WinSeparator
benknoble and others added 30 commits October 24, 2022 12:00
Update treesitter highlight groups
Fix don't interrupt the cursorline
Co-authored-by: D. Ben Knoble <ben.knoble+github@gmail.com>
* Add DraculaInlay hint and link from LspInlayHint

* drop italic attribute
/dracula-pro.png -- 357.49kb -> 331.25kb (7.34%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
nvim-treesitter and subsequently neovim is aligning their
capture/highlight groups with upstream tree-sitter. This adds groups as
of nvim 0.10 (unreleased). Existing groups are untouched.
Define plugin and syntax highlight groups in the colors/dracula.vim file
instead of in the /after directory.

Fixes: #280
Fixes: #320
Remove the use of the /after directory for defining plugin and syntax highligts.
I've used cyan colors for matched text, but kept backgrounds the same.

These features were implemented by
vim/vim@40c1c33,
and there is ongoing discussion about some edge-cases and odd behavior
IIUC.

Close #325
colors: support new PmenuMatch{,Sel}
Prior to Neovim 0.10.0, NormalFloat was linked to Pmenu. Neovim 0.10.0
changed this to support their new default colors. This patch reapplies
the old behavior. See also screenshots in
#327.

Close #322
The plugin blink.cmp [1] has officially released version 1.0. With the
API now stable, Dracula can provide support for its highlight groups.
Define the blink item highlight groups (they're defined like the ones
for nvim-cmp). This allows users to use blink's highlight groups
directly instead of having to rely on the ones from nvim-cmp.

According to the docs from blink, the option to link the highlight
groups from blink to those from nvim-cmp is going to be removed in a
future release, so this additionally future proofs the Dracula theme
against this eventuality.

[1]: https://github.com/Saghen/blink.cmp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.