Skip to content

feat: honor canonical glide time for slide notes#1051

Closed
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-filter-envelope-editorfrom
feat/v0.0.x-sprint-01-glide-runtime
Closed

feat: honor canonical glide time for slide notes#1051
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-filter-envelope-editorfrom
feat/v0.0.x-sprint-01-glide-runtime

Conversation

@ChuxiJ
Copy link
Copy Markdown

@ChuxiJ ChuxiJ commented Mar 27, 2026

Summary

  • make slide-note playback honor positive canonical subtractive glideTime values instead of always overriding them with a fixed heuristic
  • keep the existing heuristic as a fallback for zero-glide subtractive instruments, FM instruments, and legacy preset sources
  • add focused node-environment tests for canonical override and fallback behavior

Why

Sprint 01 already exposes Glide Time in the synth editor and stores it in canonical track.instrument, but slide-note playback still ignored that value. This PR closes that runtime parity gap without changing the established feel for legacy/default slide playback.

Verification

  • npx tsc --noEmit
  • npx vitest run --environment node src/engine/__tests__/SynthEngine.test.ts
  • npm run build

Notes

  • This PR intentionally stays engine-only. It does not change the editor UI or store schema.

Copy link
Copy Markdown
Author

ChuxiJ commented Mar 27, 2026

Triage: Hold — Stacked on synth improvement chain. Depends on #1019.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant