feat: honor canonical glide time for slide notes#1051
Closed
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-filter-envelope-editorfrom
Closed
feat: honor canonical glide time for slide notes#1051ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-filter-envelope-editorfrom
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-filter-envelope-editorfrom
Conversation
31 tasks
Author
|
Triage: Hold — Stacked on synth improvement chain. Depends on #1019. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glideTimevalues instead of always overriding them with a fixed heuristicWhy
Sprint 01 already exposes
Glide Timein the synth editor and stores it in canonicaltrack.instrument, but slide-note playback still ignored that value. This PR closes that runtime parity gap without changing the established feel for legacy/default slide playback.Verification
npx tsc --noEmitnpx vitest run --environment node src/engine/__tests__/SynthEngine.test.tsnpm run buildNotes