Fix omxplayer with correct volume/gain calculations#21
Open
Djadih wants to merge 4 commits intoachaudhry:masterfrom
Open
Fix omxplayer with correct volume/gain calculations#21Djadih wants to merge 4 commits intoachaudhry:masterfrom
Djadih wants to merge 4 commits intoachaudhry:masterfrom
Conversation
fix the omxplayer replacement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #17 made by brother amaklad. However it was missing the fixes for volume/gain, which led to the audio appearing not to play.