Fix: mobile Find Us layout #127
Open
+35
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CadeJordan
requested changes
Nov 24, 2025
Collaborator
CadeJordan
left a comment
CadeJordan
left a comment
There was a problem hiding this comment.
Check the Figma to see how the mobile (and desktop) version should look.
src/components/home/FindUs.tsx
Outdated
| alt="Second image of VSA Logo" | ||
| className="border-vsa-green-400 aspect-square w-1/5 border-2 object-contain" | ||
| /> | ||
| <section className="bg-vsa-yellow-100 flex flex-col items-center justify-center px-6 py-12 md:px-20 md:py-20"> |
Collaborator
There was a problem hiding this comment.
use div instead of section. Also, bg should be green and w-full.
src/components/home/FindUs.tsx
Outdated
Comment on lines
15
to
28
| <div className="mt-8 flex flex-col gap-6 md:flex-row md:items-start md:justify-center md:gap-0"> | ||
| <div className="self-end md:self-auto"> | ||
| <Image | ||
| src={VSAlogo} | ||
| alt="First image of VSA Logo" | ||
| className="border-vsa-green-400 md:w-200px md:h-200px aspect-square w-1/2 max-w-xs border-2 object-contain md:w-1/5" | ||
| /> | ||
| </div> | ||
| <div className="self-start md:self-auto"> | ||
| <Image | ||
| src={VSAlogo} | ||
| alt="Second image of VSA Logo" | ||
| className="border-vsa-green-400 md:w-200px md:h-200px aspect-square w-1/2 max-w-xs border-2 object-contain md:w-1/5" | ||
| /> |
Collaborator
There was a problem hiding this comment.
The top image should be right aligned and the bottom should be left aligned. See the figma mobile section for more details on how it should look.
src/components/home/FindUs.tsx
Outdated
Comment on lines
9
to
14
| <p className="text-vsa-brown font-vsa-main w-7/12 text-left text-4xl font-bold md:text-5xl"> | ||
| Find Us! | ||
| </p> | ||
| <p className="text-vsa-brown font-vsa-alt w-7/12 pt-4 text-left text-lg md:text-2xl"> | ||
| Come meet us at tabling by the Bell Tower every Wednesday | ||
| </p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing