Skip to content
This repository was archived by the owner on Aug 3, 2025. It is now read-only.

Conversation

@therishidesai
Copy link
Member

No description provided.

@therishidesai therishidesai requested review from a user, ASankaran and kazuki-shin August 29, 2019 02:21
Copy link
Member

@bcongdon bcongdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you're mixing tabs/spaces

@@ -0,0 +1,43 @@
<!--
Copyright © 2017, ACM@UIUC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2019

<div class="top-bar nav" border="0">
<table class="h-list" style="background-color:transparent">
<tbody>
<% for (var n of editions) { %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the sake of clarity, may want to rename this variable

app.get('/projects', function(req, res) {
res.render('desktop/projects', {
authenticated: utils.isAuthenticated(req),
editions: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to projects or something (see above)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants