fix: Correct critical bugs and improve code quality

Languages/C++/Hangman.cpp

@@ -25,19 +25,19 @@ int main()
 	cout<<"Player's 1 turn.Player 1 needs to enter word-";
 	getline(cin,word);  //Input String
 	cout<<word<<endl;;
-	cout<<"Enter hint for Player 2-";
-	getline(cin,hint);
-	cout<<hint<<endl;
-	for(i=0;word[i]!='&#092;&#048;';i++)
+    cout<<"Enter hint for Player 2-";
+    getline(cin,hint);
+    cout<<hint<<endl;
+	for(i=0; i < word.length(); i++)
 		word[i]=toupper(word[i]); //Convert the input String into uppercase
 
 
-	system("clear"); // Clear the entered string
+	cout << string(50, '\n'); // Clear the screen in a portable way
 	cout<<"\nNow It is time for Player 2 to guess ";
 
-	for(i=0;word[i]!='&#092;&#048;';i++)
+	duplicate.resize(word.length(), '-'); // Properly size the duplicate string
+	for(i=0; i < word.length(); i++)
 	{	cout<<"-" ; //Convert the input String into dashes
-	    duplicate[i]='-';
 	}
 
 	cout<<"\n\n";
@@ -59,9 +59,9 @@ int main()
 			cin>>letter;
 			letter=toupper(letter); // Convert into Upper case
 			cout<<letter<<endl;
-			used[number]=letter;// To show used letters
+			used += letter; // Append used letter to the string
 
-			for(i=0;word[i]!='&#092;&#048;';i++)
+			for(i=0; i < word.length(); i++)
 				if(word[i]==letter) // To check whether character is present
 				{
 					duplicate[i]=word[i];
@@ -82,8 +82,8 @@ int main()
 				cout<<endl;
 			}
 			cout<<"Letter used\n";
-			for(int f=1;f<=number;f++)
-				cout<<used[f]<<","; //To display used letters
+			for(char used_char : used)
+				cout << used_char << ","; //To display used letters
 			cout<<endl<<endl;
 			if(chances==0)
 			{
@@ -95,8 +95,8 @@ int main()
 		{
 			cout<<"Enter word-";
 		    cin>>guess;
-			cout<<guess<<endl;
-			for(i=0;guess[i]!='&#092;&#048;';i++)
+            cout<<guess<<endl;
+			for(i=0; i < guess.length(); i++)
 		        guess[i]=toupper(guess[i]); //Convert the input String into uppercase
 
 			int x = word.compare(guess); // 0 if strings are same

Languages/Javascript/ConnectFour Game/registration.js

@@ -119,17 +119,19 @@
                 //All of the keys should point to user data except loggedInUser
                 if(key !== "loggedInUser"){
                     //Extract object containing user data
+                    var usrObj = JSON.parse(localStorage[key]);
 
                     //Extract user name and top score
-                    htmlStr += "David";
+                    htmlStr += "<tr><td>" + usrObj.username + "</td><td>" + usrObj.topscore + "</td></tr>";
                     //Add a table row to the HTML string.
                 }
             }
 
             //Finish off the table
             htmlStr += "</table>";
-           
+
             //Add the table to the page.
+            rankingDiv.innerHTML = htmlStr;
 
         }
 

Languages/Javascript/Dodgeball/loginregister.html

@@ -63,10 +63,10 @@ <h1>Login</h1>
         <script>
 
         // Does some basic checking of user data then stores user data in localStorage
+        // WARNING: Storing passwords in localStorage is not secure. This is for demonstration only.
         function registerUser(){
 
             var usrObject = {};
-
             //Extract the name and password that the user has entered
             usrObject.registername = document.getElementById("registername").value;
             usrObject.registerpassword = document.getElementById("registerpassword").value;
@@ -79,23 +79,23 @@ <h1>Login</h1>
         }
 
         function checkLogin(){ //extract details of logged in user
-            if(localStorage.loggedInUsrEmail !-- undefined){
-                var usrObj = JSON.parse(localStorage[localStorage.loggedinUsrEmail]);
+            if(localStorage.loggedInUsrEmail !== undefined){
+                var usrObj = JSON.parse(localStorage.getItem(localStorage.loggedInUsrEmail));
                 document.getElementById("loginPara").innerHTML = usrObj.registername + "logged in."; //greet logged in user
             }
 
         }
 
         function login(){
-            var email = document.getElementById("registeremail").value; //get email address
-            
+            var email = document.querySelector("#loginPara #registeremail").value; //get email address from login form
+
             if(localStorage[email] === undefined) { //users that dont have account
                 document.getElementById("loginFailure").innerHTML = "Email not recognised. Do you have an account?"; //inform failure to user
                 return;
             }
             else{
                 var usrObj = JSON.parse(localStorage[email]); //convert to object
-                var password = document.getElementById("registerpassword").value;
+                var password = document.querySelector("#loginPara #registerpassword").value;
                 if (password === usrObj.registerpassword){ //successful login
                     document.getElementById("loginPara").innerHTML = usrObj.registername + "logged in.";
                     document.getElementById("loginFailure").innerHTML = ""; // clear login failures